From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38314 invoked by alias); 18 Nov 2019 21:12:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38306 invoked by uid 89); 18 Nov 2019 21:12:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 21:12:19 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0514920393; Mon, 18 Nov 2019 16:12:17 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 26C8B2012A; Mon, 18 Nov 2019 16:12:13 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0BD932816F; Mon, 18 Nov 2019 16:12:13 -0500 (EST) X-Gerrit-PatchSet: 10 Date: Mon, 18 Nov 2019 21:12:00 -0000 From: "Simon Marchi (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v10] Update Gnulib to the latest git version X-Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa X-Gerrit-Change-Number: 681 X-Gerrit-ChangeURL: X-Gerrit-Commit: c55713b67d15d3148a1a1a13340390e16c3ca3fa In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 16:12:12 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118211213.0BD932816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00553.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/681 ...................................................................... Patch Set 10: -Code-Review > Patch Set 10: Code-Review+2 > > Patchset 10 looks good to me. > > Note that setting MAKEOVERRIDES to empty disables all the variables passed from top-level, not just CC. I really don't know if that's an issue or not. If this causes an issue for somebody, I guess they will speak up. > > Since this is quite a big change, can you wait a few days before pushing this to give others a bit of time to try it? Actually, I ran update-gnulib.sh and got a diff, I think you forgot to add the generated changes in gnulib/Makefile.in in your last version. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa Gerrit-Change-Number: 681 Gerrit-PatchSet: 10 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Mon, 18 Nov 2019 21:12:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment