From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125337 invoked by alias); 18 Nov 2019 18:46:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125325 invoked by uid 89); 18 Nov 2019 18:46:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 18:46:08 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DF59320393; Mon, 18 Nov 2019 13:46:06 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id B8D9E20373; Mon, 18 Nov 2019 13:46:05 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 671782816F; Mon, 18 Nov 2019 13:46:05 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Mon, 18 Nov 2019 18:46:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] gdb/testsuite: Introduce skip_ctf_tests guard function X-Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63 X-Gerrit-Change-Number: 121 X-Gerrit-ChangeURL: X-Gerrit-Commit: 739180bcf798c08061e270b0cdd740a08494244c In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 13:46:04 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118184605.671782816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00537.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121 ...................................................................... Patch Set 3: (2 comments) | --- gdb/testsuite/gdb.base/ctf-whatis.exp | +++ gdb/testsuite/gdb.base/ctf-whatis.exp | @@ -14,13 +14,13 @@ # You should have received a copy of the GNU General Public License | # along with this program. If not, see . | | # This file is a subset of whatis.exp written by Rob Savoye. (rob@cygnus.com) | | -# | -# test running programs | -# | -# -gt generates full-fledged CTF. | +if ![compiler_supports_ctf_debug] { | + return 0 PS1, Line 19: > > https://sourceware.org/ml/gdb-patches/2019-10/msg00450.html reviews a very similar patch. There I suggested using "unsupported" in these cases, since I think this is the current style. > > I think that makes sense, as it leaves a trace in the .sum file. Done. | +} | | standard_testfile .c | -set opts "additional_flags=-gt" | - | + | +# Using `-gt` generates full-fledged CTF debug information. | +set opts "additional_flags=-gt" | if { [prepare_for_testing "failed to prepare" ${testfile} \ | --- gdb/testsuite/lib/gdb.exp | +++ gdb/testsuite/lib/gdb.exp | @@ -6734,8 +6734,19 @@ proc cmp_file_string { file str msg } { | pass "$msg" | } else { | fail "$msg" | } | } | | +# Does the compiler support CTF debug output using '-gt' compiler | +# flag? | +gdb_caching_proc compiler_supports_ctf_debug { | + verbose -log "APB: Got here." PS1, Line 6743: > Was it your intention to leave this logging line here? Done. | + return [gdb_can_simple_compile ctfdebug { | + int main () { | + return 0; | + } | + } executable "additional_flags=-gt"] | +} | + | # Always load compatibility stuff. | load_lib future.exp -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63 Gerrit-Change-Number: 121 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Simon Marchi Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Mon, 18 Nov 2019 18:46:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tom Tromey Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment