From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81868 invoked by alias); 18 Nov 2019 18:03:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81856 invoked by uid 89); 18 Nov 2019 18:03:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=stray X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 18:03:53 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 473AA2041E; Mon, 18 Nov 2019 13:03:51 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 539642012A; Mon, 18 Nov 2019 13:03:50 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 38A112816F; Mon, 18 Nov 2019 13:03:50 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Mon, 18 Nov 2019 18:03:00 -0000 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] gdb/testsuite: Introduce skip_ctf_tests guard function X-Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63 X-Gerrit-Change-Number: 121 X-Gerrit-ChangeURL: X-Gerrit-Commit: 739180bcf798c08061e270b0cdd740a08494244c In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 13:03:49 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118180350.38A112816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00533.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121 ...................................................................... Patch Set 3: In this revision I've: 1. Changed the name of the guard function to skip_cft_tests, this matches what Nick used in his patch series. I liked that name more, 2. Made use of unsupported when we skip ctf test files, 3. Removed the stray logging line I left in. This patch does overlap with https://sourceware.org/ml/gdb-patches/2019-10/msg00450.html in its introduction of the guard function, but that patch covers other issues too. This series goes on to rewrite some of the ctf test files, something that's not covered in Nick's patch. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63 Gerrit-Change-Number: 121 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Simon Marchi Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Mon, 18 Nov 2019 18:03:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment