From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review] Add no-dist to gnulib configure
Date: Sun, 17 Nov 2019 20:18:00 -0000 [thread overview]
Message-ID: <20191117201809.0688F2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573851599000.I5224e18af9acd5284acb79d5756b0e84b00406e9@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/659
......................................................................
Patch Set 1:
(1 comment)
| --- gnulib/aclocal.m4
| +++ gnulib/aclocal.m4
| @@ -14,19 +14,9 @@ # PARTICULAR PURPOSE.
| m4_ifndef([AC_CONFIG_MACRO_DIRS], [m4_defun([_AM_CONFIG_MACRO_DIRS], [])m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])])
| m4_ifndef([AC_AUTOCONF_VERSION],
| [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl
| m4_if(m4_defn([AC_AUTOCONF_VERSION]), [2.69],,
| [m4_warning([this file was generated for autoconf 2.69.
| You have another version of autoconf. It may work, but is not guaranteed to.
| If you have problems, you may need to regenerate the build system entirely.
| To do so, use the procedure documented by the package, typically 'autoreconf'.])])
|
| -# po.m4 serial 24 (gettext-0.19)
PS1, Line 23:
Turns out that the solution was not to compile my own gettext. That
way, my self-compiled aclocal won't find any gettext macros, and will
only use config/po.m4 (which seems to be rather oudated).
| -dnl Copyright (C) 1995-2014, 2016 Free Software Foundation, Inc.
| -dnl This file is free software; the Free Software Foundation
| -dnl gives unlimited permission to copy and/or distribute it,
| -dnl with or without modifications, as long as this notice is preserved.
| -dnl
| -dnl This file can be used in projects which are not available under
| -dnl the GNU General Public License or the GNU Library General Public
| -dnl License but which still want to provide support for the GNU gettext
| -dnl functionality.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9
Gerrit-Change-Number: 659
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 17 Nov 2019 20:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment
prev parent reply other threads:[~2019-11-17 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 21:00 Tom Tromey (Code Review)
2019-11-15 21:08 ` Simon Marchi (Code Review)
2019-11-15 21:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-15 21:21 ` [review] " Christian Biesinger (Code Review)
2019-11-17 6:10 ` Christian Biesinger (Code Review)
2019-11-17 18:03 ` Simon Marchi (Code Review)
2019-11-17 18:18 ` Simon Marchi (Code Review)
2019-11-17 19:39 ` Christian Biesinger (Code Review)
2019-11-17 20:18 ` Christian Biesinger (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191117201809.0688F2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox