From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55852 invoked by alias); 17 Nov 2019 19:39:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55837 invoked by uid 89); 17 Nov 2019 19:39:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Nov 2019 19:39:24 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 719B12032B; Sun, 17 Nov 2019 14:39:22 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 34C8120300; Sun, 17 Nov 2019 14:39:18 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 13F092816F; Sun, 17 Nov 2019 14:39:18 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Sun, 17 Nov 2019 19:39:00 -0000 From: "Christian Biesinger (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Cc: Christian Biesinger , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add no-dist to gnulib configure X-Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9 X-Gerrit-Change-Number: 659 X-Gerrit-ChangeURL: X-Gerrit-Commit: e176f82170871202640d53d8edc0caa5c450901f In-Reply-To: References: X-Gerrit-Comment-Date: Sun, 17 Nov 2019 14:39:17 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191117193918.13F092816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00507.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/659 ...................................................................... Patch Set 1: (1 comment) | --- gnulib/aclocal.m4 | +++ gnulib/aclocal.m4 | @@ -14,19 +14,9 @@ # PARTICULAR PURPOSE. | m4_ifndef([AC_CONFIG_MACRO_DIRS], [m4_defun([_AM_CONFIG_MACRO_DIRS], [])m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])]) | m4_ifndef([AC_AUTOCONF_VERSION], | [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl | m4_if(m4_defn([AC_AUTOCONF_VERSION]), [2.69],, | [m4_warning([this file was generated for autoconf 2.69. | You have another version of autoconf. It may work, but is not guaranteed to. | If you have problems, you may need to regenerate the build system entirely. | To do so, use the procedure documented by the package, typically 'autoreconf'.])]) | | -# po.m4 serial 24 (gettext-0.19) PS1, Line 23: Hm... there must be more to it than that; I am using autoconf and automake I built myself (automake 1.15.1, autoconf 2.69). I also built gettext myself from upstream, version 0.19.8.1. Let me try building gettext 0.20.1... | -dnl Copyright (C) 1995-2014, 2016 Free Software Foundation, Inc. | -dnl This file is free software; the Free Software Foundation | -dnl gives unlimited permission to copy and/or distribute it, | -dnl with or without modifications, as long as this notice is preserved. | -dnl | -dnl This file can be used in projects which are not available under | -dnl the GNU General Public License or the GNU Library General Public | -dnl License but which still want to provide support for the GNU gettext | -dnl functionality. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9 Gerrit-Change-Number: 659 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Sun, 17 Nov 2019 19:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Biesinger Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment