From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3449 invoked by alias); 17 Nov 2019 18:03:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3431 invoked by uid 89); 17 Nov 2019 18:03:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=0201 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Nov 2019 18:03:26 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7386F20250; Sun, 17 Nov 2019 13:03:24 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C07A4201E8; Sun, 17 Nov 2019 13:03:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 84E602816F; Sun, 17 Nov 2019 13:03:22 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Sun, 17 Nov 2019 18:03:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add no-dist to gnulib configure X-Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9 X-Gerrit-Change-Number: 659 X-Gerrit-ChangeURL: X-Gerrit-Commit: e176f82170871202640d53d8edc0caa5c450901f In-Reply-To: References: X-Gerrit-Comment-Date: Sun, 17 Nov 2019 13:03:21 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191117180322.84E602816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00505.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/659 ...................................................................... Patch Set 1: (1 comment) | --- gnulib/aclocal.m4 | +++ gnulib/aclocal.m4 | @@ -14,19 +14,9 @@ # PARTICULAR PURPOSE. | m4_ifndef([AC_CONFIG_MACRO_DIRS], [m4_defun([_AM_CONFIG_MACRO_DIRS], [])m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])]) | m4_ifndef([AC_AUTOCONF_VERSION], | [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl | m4_if(m4_defn([AC_AUTOCONF_VERSION]), [2.69],, | [m4_warning([this file was generated for autoconf 2.69. | You have another version of autoconf. It may work, but is not guaranteed to. | If you have problems, you may need to regenerate the build system entirely. | To do so, use the procedure documented by the package, typically 'autoreconf'.])]) | | -# po.m4 serial 24 (gettext-0.19) PS1, Line 23: > So... this change seems unrelated. And unfortunately. when I run aclocal myself, it comes back. Do you have any idea what you did that makes aclocal not insert this block of code? (What's your gettext version?) I don't see it coming back both when I run the update-gnulib.sh script and when I run aclocal by hand in I'm using autoconf and automake I built myself, and gettext 0.20.1 from the distro (Arch, and there doesn't seem to be any patches that would change this behavior). Can you give details about your setup so that we can try it our our side? | -dnl Copyright (C) 1995-2014, 2016 Free Software Foundation, Inc. | -dnl This file is free software; the Free Software Foundation | -dnl gives unlimited permission to copy and/or distribute it, | -dnl with or without modifications, as long as this notice is preserved. | -dnl | -dnl This file can be used in projects which are not available under | -dnl the GNU General Public License or the GNU Library General Public | -dnl License but which still want to provide support for the GNU gettext | -dnl functionality. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9 Gerrit-Change-Number: 659 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Sun, 17 Nov 2019 18:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Biesinger Gerrit-MessageType: comment