From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: [review] gdb: fix build error in unittests/vec-utils-selftests.c
Date: Thu, 14 Nov 2019 11:19:00 -0000 [thread overview]
Message-ID: <20191114111912.CD45B20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573700165000.I323361b1c120bf8525613b74e7e5983910e002df@gnutoolchain-gerrit.osci.io>
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/626
......................................................................
Patch Set 1: Code-Review+2
Sorry for introducing this breakage. Oddly I tried on a GCC 10 built from git a few weeks ago and I don't see the build warning/error.
Anyway, I tested that with this patch the original bug in unordered_remove is still detected, so this LGTM.
Thanks for picking up after me :)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I323361b1c120bf8525613b74e7e5983910e002df
Gerrit-Change-Number: 626
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Thu, 14 Nov 2019 11:19:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-14 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 2:56 Simon Marchi (Code Review)
2019-11-14 9:00 ` Tom de Vries (Code Review)
2019-11-14 11:19 ` Andrew Burgess (Code Review) [this message]
2019-11-14 11:53 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-14 11:53 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114111912.CD45B20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox