From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40268 invoked by alias); 14 Nov 2019 09:00:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40247 invoked by uid 89); 14 Nov 2019 09:00:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 09:00:24 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id EC8CC203AF; Thu, 14 Nov 2019 04:00:18 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 446DA203A6; Thu, 14 Nov 2019 04:00:14 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 20AD320AF6; Thu, 14 Nov 2019 04:00:14 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 14 Nov 2019 09:00:00 -0000 From: "Tom de Vries (Code Review)" To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: fix build error in unittests/vec-utils-selftests.c X-Gerrit-Change-Id: I323361b1c120bf8525613b74e7e5983910e002df X-Gerrit-Change-Number: 626 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0d0ee819ea178b2cf9e603ec656548c96a216f61 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 14 Nov 2019 04:00:13 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191114090014.20AD320AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00375.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/626 ...................................................................... Patch Set 1: Code-Review+1 I also looked at this and came up with the similar: ... diff --git a/gdb/unittests/vec-utils-selftests.c b/gdb/unittests/vec-utils-selftests.c index 823bbb61c25..61b9851dfd9 100644 --- a/gdb/unittests/vec-utils-selftests.c +++ b/gdb/unittests/vec-utils-selftests.c @@ -45,6 +45,9 @@ unordered_remove_tests () this->var = other.var; return *this; } + + obj () {} + obj (const obj &other) {} }; std::vector v; ... I've tested your patch, and can confirm it fixes my build. LGTM. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I323361b1c120bf8525613b74e7e5983910e002df Gerrit-Change-Number: 626 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Marchi Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom de Vries Gerrit-Comment-Date: Thu, 14 Nov 2019 09:00:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment