From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46034 invoked by alias); 13 Nov 2019 03:41:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46026 invoked by uid 89); 13 Nov 2019 03:41:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Nov 2019 03:41:27 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C41C62047F; Tue, 12 Nov 2019 22:41:24 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id F1503201E8; Tue, 12 Nov 2019 22:41:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id CD84D20AF6; Tue, 12 Nov 2019 22:41:22 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Wed, 13 Nov 2019 03:41:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Pedro Alves , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] Import the strerror_r-posix module and use it in GDB. X-Gerrit-Change-Id: I5cfeb12a5203a4cd94a78581541e6085a68685c3 X-Gerrit-Change-Number: 514 X-Gerrit-ChangeURL: X-Gerrit-Commit: dd60b7c9b5e77662e5fa48ad17750bc4b0e32ba7 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 22:41:22 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191113034122.CD84D20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00354.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514 ...................................................................... Patch Set 5: > Patch Set 4: Code-Review+2 > > This is OK. Thanks for doing this. > > With this, do you still see a reason for mingw not using the posix-strerror.c version too? > > I think this code in strerror-override.c ends up being equivalent to the FormatMessage call: > > # if HAVE_WINSOCK2_H > /* WSA_INVALID_HANDLE maps to EBADF */ > /* WSA_NOT_ENOUGH_MEMORY maps to ENOMEM */ > /* WSA_INVALID_PARAMETER maps to EINVAL */ > case WSA_OPERATION_ABORTED: > return "Overlapped operation aborted"; > case WSA_IO_INCOMPLETE: > return "Overlapped I/O event object not in signaled state"; > case WSA_IO_PENDING: > ... > > ... even if the messages may change a little. Yes, I believe that's correct. I was wondering about pex_run but that takes care to use ENOENT, etc. I will make a patch for that. Meanwhile I will have to land https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622 before this patch, or else string.h won't be regenerated correctly, leading to compile errors unless you blow away your build directory... -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5cfeb12a5203a4cd94a78581541e6085a68685c3 Gerrit-Change-Number: 514 Gerrit-PatchSet: 5 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Pedro Alves Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 13 Nov 2019 03:41:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment