From: "Sourceware to Gerrit sync (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [pushed] Consolidate setting of current_layout
Date: Tue, 12 Nov 2019 19:46:00 -0000 [thread overview]
Message-ID: <20191112194008.AD33F20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572212661000.Id8b23797d68e607f0fcd6d29b8801869d40d1869@gnutoolchain-gerrit.osci.io>
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/363
......................................................................
Consolidate setting of current_layout
Currently several functions in tui-layout.c set current_layout after
their work is done. This moves this assignment to show_layout,
instead.
gdb/ChangeLog
2019-11-12 Tom Tromey <tom@tromey.com>
* tui/tui-layout.c (show_layout): Set current_layout.
(show_source_disasm_command, show_data)
(show_source_or_disasm_and_command): Don't set current_layout.
Change-Id: Id8b23797d68e607f0fcd6d29b8801869d40d1869
---
M gdb/ChangeLog
M gdb/tui/tui-layout.c
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f1a05e2..23095e0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2019-11-12 Tom Tromey <tom@tromey.com>
+ * tui/tui-layout.c (show_layout): Set current_layout.
+ (show_source_disasm_command, show_data)
+ (show_source_or_disasm_and_command): Don't set current_layout.
+
+2019-11-12 Tom Tromey <tom@tromey.com>
+
* tui/tui-layout.c (_initialize_tui_layout): Move to end.
2019-11-12 Tom Tromey <tom@tromey.com>
diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index c7f6545..ba0b367 100644
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -91,6 +91,7 @@
break;
}
+ current_layout = layout;
tui_delete_invisible_windows ();
}
}
@@ -418,7 +419,6 @@
tui_term_width (),
0,
tui_term_height () - cmd_height);
- current_layout = SRC_DISASSEM_COMMAND;
}
@@ -461,8 +461,6 @@
0, total_height - 1);
TUI_CMD_WIN->resize (TUI_CMD_WIN->height, tui_term_width (),
0, total_height);
-
- current_layout = new_layout;
}
void
@@ -541,7 +539,6 @@
tui_term_width (),
0,
src_height);
- current_layout = layout_type;
}
\f
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id8b23797d68e607f0fcd6d29b8801869d40d1869
Gerrit-Change-Number: 363
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: merged
prev parent reply other threads:[~2019-11-12 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 21:50 [review] " Tom Tromey (Code Review)
2019-11-06 14:27 ` [review v2] " Tom Tromey (Code Review)
2019-11-12 17:00 ` Andrew Burgess (Code Review)
2019-11-12 19:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 19:46 ` Sourceware to Gerrit sync (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112194008.AD33F20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=noreply@gnutoolchain-gerrit.osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox