From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72217 invoked by alias); 12 Nov 2019 19:39:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72165 invoked by uid 89); 12 Nov 2019 19:39:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1388 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2019 19:39:18 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D7DBE20456; Tue, 12 Nov 2019 14:39:16 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id CBD5C203AC; Tue, 12 Nov 2019 14:39:11 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B1DBC20AF6; Tue, 12 Nov 2019 14:39:11 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 12 Nov 2019 19:39:00 -0000 From: "Christian Biesinger (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Do not static assert symbol size on Windows X-Gerrit-Change-Id: I51940fb2240c474838b48494b5072081701789bb X-Gerrit-Change-Number: 611 X-Gerrit-ChangeURL: X-Gerrit-Commit: aa9898559c2dcb22fd1c4a746e729350f79bd624 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 14:39:11 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112193911.B1DBC20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00329.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/611 ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: Code-Review+1 > > > > Hmm, this change seems fine but I am curious about your build setup that makes this necessary? These asserts do not fail for me on Mingw 64bit with g++ 9.2 > > I built using `--host=i686-w64-mingw32` on x86-64 Fedora 29. Otherwise, I didn't > do anything special. So, I don't know why there is a difference here. > > I think, though, that we should probably just remove these asserts. There was > another build failure reported to bugzilla, and then we had an internal build > failure on PPC here at AdaCore. Yeah, sounds like that may be the best option. (ah, you built for 32 bit, that's probably the difference) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I51940fb2240c474838b48494b5072081701789bb Gerrit-Change-Number: 611 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Tue, 12 Nov 2019 19:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment