[review] infcall, c++: collect more pass-by-reference information

["Tankut Baris Aktemur (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tankut Baris Aktemur has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/137
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/gnu-v3-abi.c
| +++ gdb/gnu-v3-abi.c
| @@ -1272,9 +1409,14 @@ gnuv3_pass_by_reference (struct type *type)
|       See c++98 section 12.8 Copying class objects [class.copy].  */
|    if (gnuv3_dynamic_class (type))
| -    {
| -      info.trivially_copyable = false;
| -      return info;
| -    }
| -
| +    is_dynamic = true;
| +
| +  /* FIXME taktemur/2019-04-23: What if there are multiple copy ctors?

PS1, Line 1413:

Thanks for the suggestion.  I think overload resolution will work.  It
will thus increase the coverage of this series, and also simplify the
definition of the `language_pass_by_ref_info` struct.

There is one problem, though.  GDB picks the move constructor as a
result of overload resolution, instead of the copy constructor.  I
detected that there is a bug in GDB's ranking mechanism.  I'll propose
a patch to fix it.  For the moment I'm keeping this series on hold.

| +     E.g.:
| +       class C {
| +       public:
| +	 C (C &c) { ... }
| +	 C (const C &c) { ... }
| +       };
| +  */
|    for (fieldnum = 0; fieldnum < TYPE_NFN_FIELDS (type); fieldnum++)
|      for (fieldelem = 0; fieldelem < TYPE_FN_FIELDLIST_LENGTH (type, fieldnum);

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic05bd98a962d07ec3c1ad041f709687eabda3bb9
Gerrit-Change-Number: 137
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Tue, 12 Nov 2019 15:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment