From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34061 invoked by alias); 10 Nov 2019 22:27:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34052 invoked by uid 89); 10 Nov 2019 22:27:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=basically, H*RU:sk:host86-, HX-Spam-Relays-External:sk:host86-, H*r:sk:host86- X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Nov 2019 22:27:35 +0000 Received: by mail-wm1-f67.google.com with SMTP id 8so11373095wmo.0 for ; Sun, 10 Nov 2019 14:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pHquEZ556oDiTW9k8m3hjDAXvy2oiZlzcme4ryYA7t4=; b=BtjCvzFjH0BweRj1Q1EuqOyNG2b1ie9vqdxAIIXJQx+9bHydJnj7kNB8yUjNi3FnkJ ZwoqGFFYOzlG5tdz17j+j2NovdkRtfqPfeD+HR7nkFo3mESmO2nGG5Wkt3b4yP9pEkji fsBCGaCzcqI13LWr4PtxxF6MjrbBZmnuH0d5RKva+YeQcWgxk3w3dK6zw90CDP5qQAIq 7kZRgMZ4Qr0WFjPROPCk/SU5CYVtVYR9kcZBMvNTJZeAGBix8xXTgmu+4QqxXLlodpKA XT5YsF1faQHeZS1pI5/ItPgenY4Q6yS3PkAfB0KPSl6SPzL2bYNVvHm9wsBhpL/N5toV KAew== Return-Path: Received: from localhost (host86-128-12-122.range86-128.btcentralplus.com. [86.128.12.122]) by smtp.gmail.com with ESMTPSA id z14sm12218830wrl.60.2019.11.10.14.27.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Nov 2019 14:27:32 -0800 (PST) Date: Sun, 10 Nov 2019 22:27:00 -0000 From: Andrew Burgess To: Christian Biesinger Cc: Simon Marchi , gdb-patches Subject: Re: [PATCH] gdb/python: Introduce gdb.lookup_all_static_symbols Message-ID: <20191110222731.GH11037@embecosm.com> References: <20191015164647.1837-1-andrew.burgess@embecosm.com> <32eba92d-55a9-5694-cec5-80001d8ff1ae@simark.ca> <20191023191354.GH4962@embecosm.com> <20191101115304.GR4962@embecosm.com> <20191104171204.GB11037@embecosm.com> <20093265-f125-8668-d7ba-0c36b07a53ec@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: To err is human, to moo bovine. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00278.txt.bz2 * Christian Biesinger [2019-11-09 00:23:00 -0600]: > On Mon, Nov 4, 2019 at 12:28 PM Simon Marchi wrote: > > > > On 2019-11-04 12:12 p.m., Andrew Burgess wrote: > > > How about I merged patches #1 and #2, but drop #3 for now? This would > > > give: > > > > > > lookup_static_symbol - returns the global static symbol for the > > > current compilation unit, or whatever else GDB can find if > > > there's nothing in the current CU. This is basically inline > > > with what we get from 'print symbol_name' at the CLI (if we > > > limit symbol_name to just global static things). > > > > > > AND, > > > > > > lookup_static_symbols - returns the list of all global static > > > symbols. > > > > > > We no longer have a block parameter passed to 'lookup_static_symbol', > > > so hopefully and confusion can be avoided. If/when we later add a > > > Python wrapper for CU we can _extend_ the API for lookup_static_symbol > > > to also take a CU and so provide the "look over there" type behaviour > > > in a clearer way. > > > > > > Would everyone be happy with this? > > > > I certainly would, I think that brings us back to the same place we were before > > it was suggested to add the block parameter, doesn't it? > > Sorry for the late reply & for confusing things -- yes, after reading > through all the discussions I think that's the best way forward. Thanks for the feedback. I've now pushed patches #1 and #2. Thanks, Andrew