From: "Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Sergio Durigan Junior <sergiodj@redhat.com>, gdb-patches@sourceware.org
Subject: [review v2] Fix crash with core + TUI + run
Date: Fri, 08 Nov 2019 23:14:00 -0000 [thread overview]
Message-ID: <20191108231431.E89F02816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572635191000.I39e2f8b538c580c8ea5bf1d657ee877e47746c8f@gnutoolchain-gerrit.osci.io>
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/483
......................................................................
Patch Set 2:
(1 comment)
> --- gdb/target.c
> +++ gdb/target.c
> @@ -569,14 +566,18 @@ target_stack::push (target_ops *t)
> - }
> + prev = m_stack[stratum];
>
> /* Now add the new one. */
> m_stack[stratum] = t;
>
> + /* And close the previous one, if it exists. */
> + if (prev != nullptr)
> + target_close (prev);
> +
PS1, Line 574:
> Soundcheck. 1... 2... 3...
Now with a quote.
> if (m_top < stratum)
> m_top = stratum;
> }
>
> /* See target.h. */
>
> void
> push_target (struct target_ops *t)
> {
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I39e2f8b538c580c8ea5bf1d657ee877e47746c8f
Gerrit-Change-Number: 483
Gerrit-PatchSet: 2
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 23:14:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Comment-In-Reply-To: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-08 23:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 19:06 [review] Make sure we have a valid target on top when pushing a new target Sergio Durigan Junior (Code Review)
2019-11-04 17:02 ` Sergio Durigan Junior (Code Review)
2019-11-05 23:52 ` Pedro Alves (Code Review)
2019-11-08 21:25 ` [review v2] Fix crash with core + TUI + run Sergio Durigan Junior (Code Review)
2019-11-08 21:26 ` [review] " Sergio Durigan Junior (Code Review)
2019-11-08 23:13 ` [review v2] " Pedro Alves (Code Review)
2019-11-08 23:14 ` Pedro Alves (Code Review) [this message]
2019-11-08 23:21 ` Pedro Alves (Code Review)
2019-11-09 0:05 ` Simon Marchi (Code Review)
2019-11-09 0:11 ` Simon Marchi (2) (Code Review)
2019-11-12 12:58 ` Pedro Alves (Code Review)
2019-11-19 0:12 ` Sergio Durigan Junior (Code Review)
2019-11-19 0:15 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-19 0:15 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108231431.E89F02816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox