From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [review] gdb: Don't reorder line table entries too much when sorting.
Date: Fri, 08 Nov 2019 11:14:00 -0000 [thread overview]
Message-ID: <20191108111422.7BD9625B28@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573172616000.Ia0309494be4cfd9dcc554f30209477f5f040b21b@gnutoolchain-gerrit.osci.io>
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/526
......................................................................
Patch Set 1:
Yes, after thinking about this patch over night I realised what I wrote was just wrong, it only works by total luck, I suspect because mostly there's not much actual sorting being done.
I still think the aim of the patch is correct, but I need a better method, I'll investigate std::stable_sort as a possibility.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b
Gerrit-Change-Number: 526
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 11:14:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-08 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 0:23 Andrew Burgess (Code Review)
2019-11-08 0:28 ` Christian Biesinger (Code Review)
2019-11-08 11:14 ` Andrew Burgess (Code Review) [this message]
2019-11-08 15:03 ` [review v2] " Andrew Burgess (Code Review)
2019-11-08 15:04 ` Andrew Burgess (Code Review)
2019-11-12 12:38 ` [review v3] " Andrew Burgess (Code Review)
2019-11-28 0:47 ` [review v4] " Andrew Burgess (Code Review)
2019-12-23 1:51 ` Andrew Burgess (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108111422.7BD9625B28@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox