From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117409 invoked by alias); 7 Nov 2019 09:45:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117365 invoked by uid 89); 7 Nov 2019 09:45:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=cool! X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2019 09:45:38 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D28E9200EF; Thu, 7 Nov 2019 04:45:36 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9B98320322; Thu, 7 Nov 2019 04:45:34 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7676325B28; Thu, 7 Nov 2019 04:45:34 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 07 Nov 2019 09:45:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Tom Tromey , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/contrib] Add words.sh script X-Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b X-Gerrit-Change-Number: 282 X-Gerrit-ChangeURL: X-Gerrit-Commit: d24c519ae276e163daf80d601cdb3c329e225c36 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 7 Nov 2019 04:45:34 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191107094534.7676325B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00203.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/282 ...................................................................... Patch Set 1: > Patch Set 1: > > Thanks, this is pretty cool! I ran a few examples and it seems very useful. > > I'd put your example of scanning all .[c|h] files into the script itself, so it is immediately obvious how to perform such action. > Done. > Something that i tried out of the box and that gave me a weird result was "./words --help". It listed words from awk i think, which is a bit odd. But since it is a basic script, it's not a big deal. Fixed by adding -- to the awk command line. Now prints: ... $ ./gdb/contrib/words.sh --help awk: /tmp/tmp.XttLdZXpeI:2: fatal: cannot open file `--help' for reading (No such file or directory) ... -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7b119c9a4519cdbf62a3243d1df2927c80813e8b Gerrit-Change-Number: 282 Gerrit-PatchSet: 1 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-Reviewer: Tom de Vries Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Thu, 07 Nov 2019 09:45:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment