From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18399 invoked by alias); 6 Nov 2019 23:14:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18364 invoked by uid 89); 6 Nov 2019 23:14:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2019 23:14:29 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id E6CD920C06; Wed, 6 Nov 2019 18:14:27 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id BAE86203A6; Wed, 6 Nov 2019 18:14:23 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 9E07E25B28; Wed, 6 Nov 2019 18:14:23 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 06 Nov 2019 23:14:00 -0000 From: "Kevin Buettner (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Pedro Alves , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add gdb_compile_openmp to lib/gdb.exp X-Gerrit-Change-Id: I94048b8b0940c707ce0529a6bcfa6e4eace49101 X-Gerrit-Change-Number: 503 X-Gerrit-ChangeURL: X-Gerrit-Commit: d50e7cd8527c61b307f06a048dcfb6e8647b9149 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 6 Nov 2019 18:14:23 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191106231423.9E07E25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00198.txt.bz2 Kevin Buettner has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp File gdb/testsuite/lib/gdb.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp@5930 PS1, Line 5930: 5887 | proc build_executable_from_specs {testname executable options args} { | ... 5925 | } else { 5926 | lappend sources_path "$srcdir/$subdir/$s" 5927 | } 5928 | } 5929 | set ret [gdb_compile_rust $sources_path "${binfile}" $options] 5930 > } elseif [string match gdb_compile_openmp $func] { 5931 > set objects {} 5932 > set i 0 5933 > foreach {s local_options} $args { 5934 > if { ! [regexp "^/" "$s"] } then { 5935 > set s "$srcdir/$subdir/$s" 5936 > } 5937 > if { [$func "${s}" "${binfile}${i}.o" object $local_options] != "" } { 5938 > untested $testname 5939 > return -1 5940 > } 5941 > lappend objects "${binfile}${i}.o" 5942 > incr i 5943 > } 5944 > set ret [$func $objects "${binfile}" executable $options] 5945 > } else { 5946 > set objects {} 5947 > set i 0 5948 > foreach {s local_options} $args { 5949 > if { ! [regexp "^/" "$s"] } then { 5950 > set s "$srcdir/$subdir/$s" 5951 > } 5952 > if { [gdb_compile "${s}" "${binfile}${i}.o" object $local_options] != "" } { 5953 > untested $testname 5954 > return -1 5955 > } 5956 > lappend objects "${binfile}${i}.o" 5957 > incr i 5958 > } 5959 > set ret [$func $objects "${binfile}" executable $options] 5960 > } 5961 | if { $ret != "" } { 5962 | untested $testname 5963 | return -1 5964 | } 5965 | > Testing comment with multiple lines selected. Selecting multiple lines seems to have worked, both in gerrit and in email. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I94048b8b0940c707ce0529a6bcfa6e4eace49101 Gerrit-Change-Number: 503 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Buettner Gerrit-Reviewer: Kevin Buettner Gerrit-Reviewer: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 06 Nov 2019 23:14:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment