From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5918 invoked by alias); 6 Nov 2019 23:05:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5867 invoked by uid 89); 6 Nov 2019 23:05:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2019 23:05:37 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 841422039A; Wed, 6 Nov 2019 18:05:35 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 87FAA2039A; Wed, 6 Nov 2019 18:05:28 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5EA0525B28; Wed, 6 Nov 2019 18:05:28 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 06 Nov 2019 23:05:00 -0000 From: "Kevin Buettner (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Pedro Alves , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add gdb_compile_openmp to lib/gdb.exp X-Gerrit-Change-Id: I94048b8b0940c707ce0529a6bcfa6e4eace49101 X-Gerrit-Change-Number: 503 X-Gerrit-ChangeURL: X-Gerrit-Commit: d50e7cd8527c61b307f06a048dcfb6e8647b9149 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 6 Nov 2019 18:05:28 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191106230528.5EA0525B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00197.txt.bz2 Kevin Buettner has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp File gdb/testsuite/lib/gdb.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp@5961 PS1, Line 5961: 5887 | proc build_executable_from_specs {testname executable options args} { | ... 5956 | lappend objects "${binfile}${i}.o" 5957 | incr i 5958 | } 5959 | set ret [$func $objects "${binfile}" executable $options] 5960 | } 5961 > if { $ret != "" } { 5962 | untested $testname 5963 | return -1 5964 | } 5965 | 5966 | return 0 > >>> (I wanted to select all lines from 5930 to 5961 to show the whole context in the email notificat […] The reason I didn't do it that way - i.e. change 'gdb_compile' to '$func" in the "else" clause - is due to the fact that the "pthreads" option uses the the "else" clause. For "pthreads", I think that we want to call gdb_compile when making the .o files and gdb_compile_pthreads when making the executable. If I make the change that you propose, then gdb_compile_pthreads is used for both executables and objects. I gave it a try with the substitution that you propose. It does work, but the log file output is somewhat different than before. Prior to making that substitution, there was a single PASS with message "successfully compiled posix threads test case". After the substitution, there are now N+1 of these messages, one for each of the N source files, plus one more for the linking phase. I can still make this change if you want; but if I do this, I think that I should also add some code to gdb_compile_pthreads so that it will call gdb_compile (and also avoid printing the PASS message) when $type is not "executable". Let me know how you'd like to proceed... -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I94048b8b0940c707ce0529a6bcfa6e4eace49101 Gerrit-Change-Number: 503 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Buettner Gerrit-Reviewer: Kevin Buettner Gerrit-Reviewer: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 06 Nov 2019 23:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment