Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review v2] Import the strerror_r-posix module and use it in GDB.
Date: Wed, 06 Nov 2019 19:59:00 -0000	[thread overview]
Message-ID: <20191106195908.E7B372816A@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573068905000.I5cfeb12a5203a4cd94a78581541e6085a68685c3@gnutoolchain-gerrit.osci.io>

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514
......................................................................


Uploaded patch set 2.

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514/1//COMMIT_MSG 
Commit Message:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514/1//COMMIT_MSG@9 
PS1, Line 9: 
 4 | Commit:     Christian Biesinger <cbiesinger@google.com>
 5 | CommitDate: 2019-11-06 13:31:05 -0600
 6 | 
 7 | Import the strerror_r-posix module and use it in GDB.
 8 | 
 9 > Makes sure to assign the return value of strerror_r to an int,
10 > so that we get a compile error if we accidentally get the
11 > wrong version.
12 | 
13 | gdb/ChangeLog:
14 | 
15 | 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
16 | 

> Can you add the same comment in the code?

Done



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5cfeb12a5203a4cd94a78581541e6085a68685c3
Gerrit-Change-Number: 514
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 06 Nov 2019 19:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment


  parent reply	other threads:[~2019-11-06 19:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 19:35 [review] " Christian Biesinger (Code Review)
2019-11-06 19:56 ` Simon Marchi (Code Review)
2019-11-06 19:59 ` Christian Biesinger (Code Review) [this message]
2019-11-06 20:00 ` [review v2] " Christian Biesinger (Code Review)
2019-11-11 19:49 ` [review v3] " Christian Biesinger (Code Review)
2019-11-11 22:22 ` [review v4] " Christian Biesinger (Code Review)
2019-11-12 13:25 ` Pedro Alves (Code Review)
2019-11-13  3:41 ` [review v5] " Christian Biesinger (Code Review)
2019-11-15 19:15 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-15 19:16 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106195908.E7B372816A@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gnutoolchain-gerrit@osci.io \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox