From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71277 invoked by alias); 6 Nov 2019 19:56:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71265 invoked by uid 89); 6 Nov 2019 19:56:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2019 19:56:48 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 80F2220555; Wed, 6 Nov 2019 14:56:46 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 6C3E4200EF; Wed, 6 Nov 2019 14:56:45 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 4D14525B28; Wed, 6 Nov 2019 14:56:45 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 06 Nov 2019 19:56:00 -0000 From: "Simon Marchi (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Import the strerror_r-posix module and use it in GDB. X-Gerrit-Change-Id: I5cfeb12a5203a4cd94a78581541e6085a68685c3 X-Gerrit-Change-Number: 514 X-Gerrit-ChangeURL: X-Gerrit-Commit: 35b4ad539a460c4485ed22e57266d09f48a27d04 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 6 Nov 2019 14:56:45 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191106195645.4D14525B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00183.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514/1//COMMIT_MSG Commit Message: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514/1//COMMIT_MSG@9 PS1, Line 9: 4 | Commit: Christian Biesinger 5 | CommitDate: 2019-11-06 13:31:05 -0600 6 | 7 | Import the strerror_r-posix module and use it in GDB. 8 | 9 > Makes sure to assign the return value of strerror_r to an int, 10 > so that we get a compile error if we accidentally get the 11 > wrong version. 12 | 13 | gdb/ChangeLog: 14 | 15 | 2019-11-06 Christian Biesinger 16 | Can you add the same comment in the code? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5cfeb12a5203a4cd94a78581541e6085a68685c3 Gerrit-Change-Number: 514 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Biesinger Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 06 Nov 2019 19:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment