From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54539 invoked by alias); 6 Nov 2019 19:37:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54523 invoked by uid 89); 6 Nov 2019 19:37:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1659 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2019 19:37:00 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 24E7220C12; Wed, 6 Nov 2019 14:36:59 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 0CC792039A; Wed, 6 Nov 2019 14:36:54 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id EF78A25B28; Wed, 6 Nov 2019 14:36:53 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Wed, 06 Nov 2019 19:37:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Hannes Domani , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Use strerror_r in safe_strerror if available X-Gerrit-Change-Id: I81048fbaf148035c221c528727f7efe58ba528eb X-Gerrit-Change-Number: 474 X-Gerrit-ChangeURL: X-Gerrit-Commit: b231e86ac9608056ea837e24d42a878927f5787a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 6 Nov 2019 14:36:53 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191106193653.EF78A25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00182.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474 ...................................................................... Patch Set 3: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474/3/gdb/gdbsupport/posix-strerror.c File gdb/gdbsupport/posix-strerror.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474/3/gdb/gdbsupport/posix-strerror.c@37 PS3, Line 37: 32 | /* Glibc has two different, incompatible versions of strerror_r. */ 33 | if (strerror_r (errnum, buf, sizeof (buf)) == 0) 34 | msg = buf; 35 | # else 36 | msg = strerror_r (errnum, buf, sizeof (buf)); 37 > # endif 38 | #else 39 | msg = strerror (errnum); 40 | #endif 41 | if (msg == nullptr) 42 | { > Any reason we don't use strerror_r from gnulib instead? […] Thanks for the suggestion, uploaded a patch for that at https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514 -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I81048fbaf148035c221c528727f7efe58ba528eb Gerrit-Change-Number: 474 Gerrit-PatchSet: 3 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-CC: Hannes Domani Gerrit-CC: Pedro Alves Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Wed, 06 Nov 2019 19:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment