From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56837 invoked by alias); 5 Nov 2019 16:31:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56821 invoked by uid 89); 5 Nov 2019 16:31:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1530 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2019 16:31:46 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 9FBE2201E0; Tue, 5 Nov 2019 11:31:44 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 9096C203A6; Tue, 5 Nov 2019 11:31:43 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 748AC25B28; Tue, 5 Nov 2019 11:31:43 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 05 Nov 2019 16:31:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: Support printf 'z' size modifier X-Gerrit-Change-Id: Ib6c44d88aa5bce265d757e4c0698881803dd186f X-Gerrit-Change-Number: 511 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4f23383e8e03e2dda242ae719402884bea64e28e In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 5 Nov 2019 11:31:43 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191105163143.748AC25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00125.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/511 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/511/1//COMMIT_MSG Commit Message: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/511/1//COMMIT_MSG@13 PS1, Line 13: 8 | 9 | The gdb format mechanism doesn't currently support the 'z' size 10 | modifier, there are a few places in GDB where this is used. Instead 11 | of removing these uses lets just add support to GDB for using 'z'. 12 | 13 > I've not added a test for this as I ran into the issue when trying to 14 > use some debug output. Before this commit: 15 | 16 | (gdb) set debug dwarf-line 9 17 | (gdb) file test 18 | Reading symbols from test... 19 | Unrecognized format specifier 'z' in printf It would seem easy enough to add an entry in test_format_specifier, in unittests/format_pieces-selftests.c, I think it would be a good idea to add it. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ib6c44d88aa5bce265d757e4c0698881803dd186f Gerrit-Change-Number: 511 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-CC: Simon Marchi Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Tue, 05 Nov 2019 16:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment