From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50482 invoked by alias); 4 Nov 2019 08:36:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50474 invoked by uid 89); 4 Nov 2019 08:36:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 08:36:01 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7040D203A5; Mon, 4 Nov 2019 03:35:59 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 60A9220266; Mon, 4 Nov 2019 03:35:58 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 384EC25B28; Mon, 4 Nov 2019 03:35:58 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 04 Nov 2019 08:36:00 -0000 From: "Tankut Baris Aktemur (Code Review)" To: gdb-patches@sourceware.org Cc: Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] infrun: mark an exited thread non-executing when attempting to stop X-Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 X-Gerrit-Change-Number: 133 X-Gerrit-ChangeURL: X-Gerrit-Commit: 411a56782f5b12f8bc852b6a163d8fed3df12ca3 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 4 Nov 2019 03:35:58 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191104083558.384EC25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00081.txt.bz2 Tankut Baris Aktemur has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133 ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > This looks like an old oversight when handling the case of exited threads when we're attempting to stop all of them. Looking at older code, we used to have a message saying a thread had exited while we were stopping it, but it was removed by a cleanup. > > The change looks good for me. Thank you. I noticed that the patch has a problem. It leaves the exited inferior in an alive state with no threads. It becomes not possible to re-run the program. I will send a revision, together with updated tests. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 Gerrit-Change-Number: 133 Gerrit-PatchSet: 1 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-Comment-Date: Mon, 04 Nov 2019 08:35:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment