From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32089 invoked by alias); 4 Nov 2019 05:34:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32074 invoked by uid 89); 4 Nov 2019 05:34:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 05:34:04 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 42314204A7; Mon, 4 Nov 2019 00:34:03 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 5B44920266; Mon, 4 Nov 2019 00:34:00 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 42ABC25B28; Mon, 4 Nov 2019 00:34:00 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 04 Nov 2019 05:34:00 -0000 From: "Christian Biesinger (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Store objfiles on a std::list X-Gerrit-Change-Id: Ib4430e3db6f9a390399924379a5c10426c514853 X-Gerrit-Change-Number: 499 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9de3916ec5b2c93ed8b0d4242cb84a8e8b0bdf5b In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 4 Nov 2019 00:34:00 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191104053400.42ABC25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00078.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/499 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/499/1/gdb/progspace.h File gdb/progspace.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/499/1/gdb/progspace.h@179 PS1, Line 179: 137 | struct program_space | ... 174 | 175 | /* Return true if there is more than one object file loaded; false 176 | otherwise. */ 177 | bool multi_objfile_p () const 178 | { 179 > return objfiles_list.size () > 1; 180 | } 181 | 182 | 183 | /* Pointer to next in linked list. */ 184 | struct program_space *next = NULL; return !objfiles_list.empty ()? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ib4430e3db6f9a390399924379a5c10426c514853 Gerrit-Change-Number: 499 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Mon, 04 Nov 2019 05:34:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment