From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 2/2] OpenMP parallel region scope tests
Date: Mon, 04 Nov 2019 04:31:00 -0000 [thread overview]
Message-ID: <20191103213119.1687945c@f29-4.lan> (raw)
In-Reply-To: <87r23xah4f.fsf@tromey.com>
On Mon, 30 Sep 2019 10:22:40 -0600
Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>
> Kevin> Add tests which check for accessibility of variables from within
> Kevin> various OpenMP parallel regions.
>
> I don't know anything about OpenMP, so I didn't read new .c file.
> I'm not especially concerned about it though.
>
> Kevin> +if {[gdb_compile_openmp "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != ""} {
>
> Over-long line.
>
> Kevin> +if {[info procs openmp_setup] != ""} {
> Kevin> + if {[openmp_setup $binfile] != ""} {
> Kevin> + return -1
>
> Does this need a call to "untested"?
>
> The rest seemed fine to me.
Thanks for the review. I've addressed both of your concerns in
my most recent patch submitted via gerrit:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/504
Kevin
next prev parent reply other threads:[~2019-11-04 4:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 17:14 [PATCH 0/2] " Kevin Buettner
2019-08-22 17:14 ` [PATCH 2/2] " Kevin Buettner
2019-09-30 16:22 ` Tom Tromey
2019-11-04 4:31 ` Kevin Buettner [this message]
2019-10-02 16:52 ` Pedro Alves
2019-11-04 4:49 ` Kevin Buettner
2019-08-22 17:14 ` [PATCH 1/2] Add gdb_compile_openmp to lib/gdb.exp Kevin Buettner
2019-08-22 17:18 ` Christian Biesinger via gdb-patches
2019-08-22 17:27 ` Kevin Buettner
2019-09-07 15:51 ` [PING][PATCH 0/2] OpenMP parallel region scope tests Kevin Buettner
2019-09-28 20:10 ` [PING 2][PATCH " Kevin Buettner
-- strict thread matches above, loose matches on Subject: below --
2017-09-27 15:27 [PATCH " Kevin Buettner
2017-09-27 15:33 ` [PATCH 2/2] " Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103213119.1687945c@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox