From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25202 invoked by alias); 1 Nov 2019 15:22:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25186 invoked by uid 89); 1 Nov 2019 15:22:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1745 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Nov 2019 15:22:34 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C584220172; Fri, 1 Nov 2019 11:22:32 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 3BC8620172; Fri, 1 Nov 2019 11:22:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 36C67218A2; Fri, 1 Nov 2019 11:22:30 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Fri, 01 Nov 2019 15:22:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey , Hannes Domani , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Use strerror_r in safe_strerror if available X-Gerrit-Change-Id: I81048fbaf148035c221c528727f7efe58ba528eb X-Gerrit-Change-Number: 474 X-Gerrit-ChangeURL: X-Gerrit-Commit: b231e86ac9608056ea837e24d42a878927f5787a In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 1 Nov 2019 11:22:30 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191101152230.36C67218A2@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00032.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474 ...................................................................... Patch Set 3: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474/3/gdb/gdbsupport/common-utils.h File gdb/gdbsupport/common-utils.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474/3/gdb/gdbsupport/common-utils.h@113 PS3, Line 113: 108 | 109 | /* The strerror() function can return NULL for errno values that are 110 | out of range. Provide a "safe" version that always returns a 111 | printable string. This version is also thread-safe. */ 112 | 113 > extern const char *safe_strerror (int); 114 | 115 | /* Return true if the start of STRING matches PATTERN, false otherwise. */ 116 | 117 | static inline bool 118 | startswith (const char *string, const char *pattern) > The windows build now fails, because safe_strerror() of mingw-strerror. […] Thanks; tromey has a patch for that at https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/478 -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I81048fbaf148035c221c528727f7efe58ba528eb Gerrit-Change-Number: 474 Gerrit-PatchSet: 3 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-CC: Hannes Domani Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Fri, 01 Nov 2019 15:22:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hannes Domani Gerrit-MessageType: comment