From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108449 invoked by alias); 1 Nov 2019 14:50:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108436 invoked by uid 89); 1 Nov 2019 14:50:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Nov 2019 14:50:14 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A066A20172; Fri, 1 Nov 2019 10:50:11 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id E4676203A6; Fri, 1 Nov 2019 10:50:09 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B589020AF6; Fri, 1 Nov 2019 10:50:09 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Fri, 01 Nov 2019 14:50:00 -0000 From: "Sergio Durigan Junior (Code Review)" To: Sergio Durigan Junior , gdb-patches@sourceware.org Cc: Tom Tromey , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Make 'target_{short,long}name' inline functions and check if 'current... X-Gerrit-Change-Id: I8a9a4dd6edc3784dc089f37d56f2d020567b4aee X-Gerrit-Change-Number: 481 X-Gerrit-ChangeURL: X-Gerrit-Commit: abd3eda0082e24acbce072dd34ff9f32c842697b In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 1 Nov 2019 10:50:09 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191101145009.B589020AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00024.txt.bz2 Sergio Durigan Junior has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481/1/gdb/target.h File gdb/target.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481/1/gdb/target.h@1312 PS1, Line 1312: 1307 | target_ops *m_stack[(int) debug_stratum + 1] {}; 1308 | }; 1309 | 1310 | /* The ops structure for our "current" target process. This should 1311 | never be NULL. If there is no target, it points to the dummy_target. */ 1312 > 1313 | extern target_ops *current_top_target (); 1314 | 1315 | /* Define easy words for doing these operations on our current target. */ 1316 | 1317 | static inline const char * > If this is the correct way to resolve this issue - I defer to others with more knowledge in this are […] You're correct, thanks for pointing this out. Even though it seemed strange that current_top_target returns NULL, I missed the comment saying that it should never do that. I guess this requires more investigation to see why this is happening. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I8a9a4dd6edc3784dc089f37d56f2d020567b4aee Gerrit-Change-Number: 481 Gerrit-PatchSet: 1 Gerrit-Owner: Sergio Durigan Junior Gerrit-Reviewer: Sergio Durigan Junior Gerrit-CC: Andrew Burgess Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Fri, 01 Nov 2019 14:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andrew Burgess Gerrit-MessageType: comment