From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31603 invoked by alias); 1 Nov 2019 13:58:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31588 invoked by uid 89); 1 Nov 2019 13:58:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Nov 2019 13:58:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D5F4820322; Fri, 1 Nov 2019 09:58:23 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 2BC7D20339; Fri, 1 Nov 2019 09:58:21 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0D59A20AF6; Fri, 1 Nov 2019 09:58:21 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Fri, 01 Nov 2019 13:58:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Christian Biesinger , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] gdb: Introduce symbol_search_spec X-Gerrit-Change-Id: I488ab292a892d9e9e84775c632c5f198b6ad3710 X-Gerrit-Change-Number: 264 X-Gerrit-ChangeURL: X-Gerrit-Commit: bc20ea5e53f9678ffe1305d10ca43317abf15440 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 1 Nov 2019 09:58:20 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191101135821.0D59A20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00023.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264 ...................................................................... Patch Set 2: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c File gdb/symtab.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c@4449 PS1, Line 4449: 4444 | } 4445 | 4446 | /* See symtab.h. */ 4447 | 4448 | std::vector 4449 > search_symbols (const search_symbols_spec &search_spec) 4450 > { 4451 > /* Unpack the search spec. */ 4452 > const char *regexp = search_spec.symbol_regexp; 4453 > enum search_domain kind = search_spec.kind; 4454 > const char *t_regexp = search_spec.type_regexp; 4455 > int nfiles = search_spec.filenames.size (); 4456 > bool exclude_minsyms = search_spec.exclude_minsyms; 4457 | 4458 | /* The search. */ 4459 | const struct blockvector *bv; 4460 | const struct block *b; 4461 | int i = 0; > I've done this in the new version of this patch. […] Then (name bikeshedding) it's not really a "search_symbols_spec", but more something like a "symbol_searcher". -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I488ab292a892d9e9e84775c632c5f198b6ad3710 Gerrit-Change-Number: 264 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Tom Tromey Gerrit-CC: Christian Biesinger Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Fri, 01 Nov 2019 13:58:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andrew Burgess Comment-In-Reply-To: Tom Tromey Gerrit-MessageType: comment