From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Sergio Durigan Junior <sergiodj@redhat.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [review] Make 'target_{short,long}name' inline functions and check if 'current...
Date: Fri, 01 Nov 2019 13:18:00 -0000 [thread overview]
Message-ID: <20191101131807.93F4820AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572586994000.I8a9a4dd6edc3784dc089f37d56f2d020567b4aee@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481
......................................................................
Patch Set 1:
(1 comment)
Probably Pedro should look at this... I wonder how it interacts with the
multi-remote series.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481/1/gdb/testsuite/gdb.tui/segfault-corefile-run.exp
File gdb/testsuite/gdb.tui/segfault-corefile-run.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481/1/gdb/testsuite/gdb.tui/segfault-corefile-run.exp@60
PS1, Line 60:
55 |
56 | Term::command "core-file $core"
57 | Term::check_contents "load corefile" "21 *return 0"
58 |
59 | Term::command "run"
60 > Term::check_contents "run until the end" "\\\[Inferior $decimal \\\(process $decimal\\\) exited normally\\]"
This line looks over-long.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I8a9a4dd6edc3784dc089f37d56f2d020567b4aee
Gerrit-Change-Number: 481
Gerrit-PatchSet: 1
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 13:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-01 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 5:43 Sergio Durigan Junior (Code Review)
2019-11-01 8:40 ` Andrew Burgess (Code Review)
2019-11-01 13:18 ` Tom Tromey (Code Review) [this message]
2019-11-01 14:50 ` Sergio Durigan Junior (Code Review)
2019-11-01 15:24 ` Sergio Durigan Junior (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101131807.93F4820AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox