From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>
Subject: [review v5] Fix disassembling bug after reloading a symbol file
Date: Fri, 01 Nov 2019 01:09:00 -0000 [thread overview]
Message-ID: <20191101010928.B6C9720AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572442722000.I22c3e6ebe9bfedad66d56fe9656994fa1761c485@gnutoolchain-gerrit.osci.io>
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447
......................................................................
Patch Set 5: Code-Review+2
LGTM.
Tom's question about arm_exidx_data_key is address by you other patch https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/448.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I22c3e6ebe9bfedad66d56fe9656994fa1761c485
Gerrit-Change-Number: 447
Gerrit-PatchSet: 5
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 01:09:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-01 1:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 13:38 [review] [ARM, Thumb] " Luis Machado (Code Review)
2019-10-30 14:01 ` Andrew Burgess (Code Review)
2019-10-30 14:11 ` Luis Machado (Code Review)
2019-10-30 14:22 ` [review v2] " Luis Machado (Code Review)
2019-10-30 15:15 ` Tom Tromey (Code Review)
2019-10-30 15:22 ` Luis Machado (Code Review)
2019-10-30 15:59 ` [review v3] " Luis Machado (Code Review)
2019-10-31 16:44 ` [review v5] " Luis Machado (Code Review)
2019-10-31 16:45 ` Luis Machado (Code Review)
2019-11-01 1:09 ` Andrew Burgess (Code Review) [this message]
2019-11-01 13:14 ` [pushed] [ARM, thumb] " Sourceware to Gerrit sync (Code Review)
2019-11-01 13:14 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101010928.B6C9720AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox