From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94392 invoked by alias); 31 Oct 2019 14:10:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94376 invoked by uid 89); 31 Oct 2019 14:10:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 14:10:48 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 89429204F8; Thu, 31 Oct 2019 10:10:46 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 311092031F; Thu, 31 Oct 2019 10:10:44 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0FB2120AF6; Thu, 31 Oct 2019 10:10:44 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Thu, 31 Oct 2019 14:10:00 -0000 From: "Simon Marchi (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: Tom Tromey , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: recognize new DWARF attributes: defaulted, deleted, calling conv. X-Gerrit-Change-Id: I54192f363115b78ec7435a8563b73fcace420765 X-Gerrit-Change-Number: 135 X-Gerrit-ChangeURL: X-Gerrit-Commit: be2a724c69fd89d32b0829d500820f9c7f448c84 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 31 Oct 2019 10:10:43 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191031141044.0FB2120AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01161.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h File gdb/gdbtypes.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@1101 PS1, Line 1101: 986 | struct cplus_struct_type | ... 1096 | 1097 | /* * The calling convention for this type, fetched from the 1098 | DW_AT_calling_convention attribute. The value is one of the 1099 | DW_CC enum dwarf_calling_convention constants. */ 1100 | 1101 > unsigned calling_convention : 8; 1102 | }; 1103 | 1104 | /* * Struct used to store conversion rankings. */ 1105 | 1106 | struct rank > I assume this comment applies to the "defaulted" attribute, too. […] Ah, thanks for pointing out this other usage in func_type. Well, if I was reviewing that, I would give the same comment there too. If we're going to document that the field takes one of the values of the dwarf_calling_convention enum, we're already depending on it implicitly. Making it explicit just makes it clearer, IMO. If you agree, I think we can change this other spot in another patch to keep it consistent. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I54192f363115b78ec7435a8563b73fcace420765 Gerrit-Change-Number: 135 Gerrit-PatchSet: 1 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-CC: Simon Marchi Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Thu, 31 Oct 2019 14:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tankut Baris Aktemur Comment-In-Reply-To: Tom Tromey Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment