From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99522 invoked by alias); 31 Oct 2019 13:19:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99366 invoked by uid 89); 31 Oct 2019 13:19:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=DW_AT_defaulted, dw_at_defaulted X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 13:19:33 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B13DF20468; Thu, 31 Oct 2019 09:19:31 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 796D62031F; Thu, 31 Oct 2019 09:19:28 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 55CE220AF6; Thu, 31 Oct 2019 09:19:28 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Thu, 31 Oct 2019 13:19:00 -0000 From: "Tankut Baris Aktemur (Code Review)" To: gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] testsuite, cp: increase the coverage of testing pass-by-ref arguments X-Gerrit-Change-Id: Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6 X-Gerrit-Change-Number: 142 X-Gerrit-ChangeURL: X-Gerrit-Commit: d677f42a7bb2d3ed6eee7678e01b2e69ff954939 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 31 Oct 2019 09:19:28 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191031131928.55CE220AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01158.txt.bz2 Tankut Baris Aktemur has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/142 ...................................................................... Patch Set 1: > Patch Set 1: > > Thank you for the patch. > > This looks pretty good to me. > > I wanted to verify that the tests failed without your series. > Yes, tests fail without the patches in the series. To give more details on this: Without the series, using g++ 8.3.0 or 7.4.0, the pass/fail result is 378/546. With the series; * using g++ 8.3.0 or 7.4.0, it is 924/0. * using g++ 5.5.0 or 6.5.0, it is 699/225. * using clang++ 7.0.0 or 8.0.0, it is 727/197. For the latter two, the main reason for failures is that the compiler does not emit the DW_AT_defaulted and DW_AT_deleted attributes. There are more passes with clang because it emits DW_AT_calling_convention, which gcc does not, and the patch I sent favors compiler's hint if it detects a conflict between the DW_AT_calling_convention and the inferred result. > Also, I think the generated file could just be generated each test run. > Then this wouldn't need a special mode to regenerate the file. > I think there are other tests that do this already. Done. I'll send this with the next revision; I want to revise the other patches in the series, too, and send the v2 in one go. Thanks. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6 Gerrit-Change-Number: 142 Gerrit-PatchSet: 1 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Thu, 31 Oct 2019 13:19:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment