From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39122 invoked by alias); 31 Oct 2019 03:54:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39107 invoked by uid 89); 31 Oct 2019 03:54:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=Non X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 03:54:39 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 75931203A5; Wed, 30 Oct 2019 23:54:37 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 49BC920322; Wed, 30 Oct 2019 23:54:36 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 1CB6120AF6; Wed, 30 Oct 2019 23:54:36 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Thu, 31 Oct 2019 03:54:00 -0000 From: "Luis Machado (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Share windows_thread_info between gdb and gdbserver X-Gerrit-Change-Id: I9ba2d1b94be1550ea2e75e977d0808c7a27e2223 X-Gerrit-Change-Number: 407 X-Gerrit-ChangeURL: X-Gerrit-Commit: 46bfa6cb85b20494fdf0e51c4a2585b3b69a584a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 30 Oct 2019 23:54:35 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191031035436.1CB6120AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01153.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) A couple nits, but otherwise LGTM. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h File gdb/nat/windows-nat.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h@1 PS1, Line 1: 1 > /* Internal interfaces for the Windows code 2 | Copyright (C) 1995-2019 Free Software Foundation, Inc. 3 | 4 | This file is part of GDB. 5 | 6 | This program is free software; you can redistribute it and/or modify Internal native interfaces maybe? https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h@35 PS1, Line 35: 24 | struct windows_thread_info | ... 30 | HANDLE h; 31 | 32 | /* Thread Information Block address. */ 33 | CORE_ADDR thread_local_base; 34 | 35 > /* Non zero if SuspendThread was called on this thread. */ 36 | int suspended; 37 | 38 | #ifdef _WIN32_WCE 39 | /* The context as retrieved right after suspending the thread. */ 40 | CONTEXT base_context; This discrepancy between Non zero here and Nonzero below caught my attention. Maybe we should fix it since we're adding new comments? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9ba2d1b94be1550ea2e75e977d0808c7a27e2223 Gerrit-Change-Number: 407 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Luis Machado Gerrit-Comment-Date: Thu, 31 Oct 2019 03:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment