From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey <tromey@sourceware.org>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review v3] [gdb/testsuite] Compile ada with -lgnarl_pic and -lgnat_pic if required
Date: Thu, 31 Oct 2019 01:35:00 -0000 [thread overview]
Message-ID: <20191031013505.5BECE20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571043363000.I3e1e40bd46236b45e2d7808c1cd744a075d4a148@gnutoolchain-gerrit.osci.io>
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32
......................................................................
Patch Set 3: Code-Review+1
The latest update looks good to me.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3e1e40bd46236b45e2d7808c1cd744a075d4a148
Gerrit-Change-Number: 32
Gerrit-PatchSet: 3
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Joel Brobecker <brobecker@adacore.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Thu, 31 Oct 2019 01:35:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-31 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571043363000.I3e1e40bd46236b45e2d7808c1cd744a075d4a148@gnutoolchain-gerrit.osci.io>
2019-10-30 17:35 ` Tom de Vries (Code Review)
2019-10-31 1:35 ` Luis Machado (Code Review) [this message]
2019-11-02 0:04 ` Joel Brobecker (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031013505.5BECE20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox