From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88639 invoked by alias); 30 Oct 2019 22:51:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88631 invoked by uid 89); 30 Oct 2019 22:51:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 22:51:04 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 40E86203AF; Wed, 30 Oct 2019 18:51:03 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 0F00220300; Wed, 30 Oct 2019 18:51:02 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id CFE4A20AF6; Wed, 30 Oct 2019 18:51:01 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 30 Oct 2019 22:51:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Defer minimal symbol name-setting X-Gerrit-Change-Id: I4fe3993b99fb3a43968067806e294d48e377fd76 X-Gerrit-Change-Number: 166 X-Gerrit-ChangeURL: X-Gerrit-Commit: 467e9ca6f19f6ee6333e725b11ea573475e9a5f8 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 30 Oct 2019 18:51:01 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191030225101.CFE4A20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01127.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/166 ...................................................................... Patch Set 2: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/166/2/gdb/minsyms.c File gdb/minsyms.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/166/2/gdb/minsyms.c@1360 PS2, Line 1360: 1286 | minimal_symbol_reader::install () | ... 1355 | m_objfile->per_bfd->msymbols = std::move (msym_holder); 1356 | 1357 | msymbols = m_objfile->per_bfd->msymbols.get (); 1358 | for (int i = 0; i < mcount; ++i) 1359 | { 1360 > if (!msymbols[i].name_set) 1361 | { 1362 | symbol_set_names (&msymbols[i], msymbols[i].name, 1363 | strlen (msymbols[i].name), 0, 1364 | m_objfile->per_bfd); 1365 | msymbols[i].name_set = 1; > I'm under the impression that multiple symbol readers can install […] Ok, I looked into this, and unfortunately this really can happen. For example, elfread.c can obviously make minimal symbols itself. After having done so, though, it can call elfstab_build_psymtabs, which calls dbx_symfile_read, which can install minimal symbols. Perhaps with some refactoring a single minimal_symbol_reader could be created and then passed around. I am not sure whether this would really be an improvement -- it may depend on the other minsym threading changes that Christian is experimenting with. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I4fe3993b99fb3a43968067806e294d48e377fd76 Gerrit-Change-Number: 166 Gerrit-PatchSet: 2 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 30 Oct 2019 22:51:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tom Tromey Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment