From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8240 invoked by alias); 30 Oct 2019 14:31:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5092 invoked by uid 89); 30 Oct 2019 14:31:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 14:31:03 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C3331203A5; Wed, 30 Oct 2019 10:31:01 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 0FEB820300; Wed, 30 Oct 2019 10:31:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id EC03C20AF6; Wed, 30 Oct 2019 10:30:59 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Wed, 30 Oct 2019 14:31:00 -0000 From: "Christian Biesinger (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Christian Biesinger , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: Introduce symbol_search_spec X-Gerrit-Change-Id: I488ab292a892d9e9e84775c632c5f198b6ad3710 X-Gerrit-Change-Number: 264 X-Gerrit-ChangeURL: X-Gerrit-Commit: 38e4dba5045aa9b6293b8484708fc5c28b1605a3 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 30 Oct 2019 10:30:59 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191030143059.EC03C20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01094.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c File gdb/symtab.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c@4359 PS1, Line 4359: 4350 | } 4351 | 4352 | /* Compare FILE against all the entries of FILENAMES. If BASENAMES is 4353 | non-zero compare only lbasename of FILENAMES. */ 4354 | 4355 | static bool 4356 | file_matches (const char *file, const std::vector &filenames, 4357 | bool basenames) 4358 | { 4359 | if (filenames.size () == 0) filenames.empty()? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I488ab292a892d9e9e84775c632c5f198b6ad3710 Gerrit-Change-Number: 264 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Tom Tromey Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Wed, 30 Oct 2019 14:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment