From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75850 invoked by alias); 30 Oct 2019 14:01:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75608 invoked by uid 89); 30 Oct 2019 14:00:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 14:00:48 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6B9A8203AF; Wed, 30 Oct 2019 10:00:43 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 6A0AA20250; Wed, 30 Oct 2019 10:00:42 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3F7AD20AF6; Wed, 30 Oct 2019 10:00:42 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Wed, 30 Oct 2019 14:01:00 -0000 From: "Andrew Burgess (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [ARM, Thumb] Fix disassembling bug after reloading a symbol file X-Gerrit-Change-Id: I22c3e6ebe9bfedad66d56fe9656994fa1761c485 X-Gerrit-Change-Number: 447 X-Gerrit-ChangeURL: X-Gerrit-Commit: 49ab7fc1b05c0ce65ebca06eb21821b0b4c00395 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 30 Oct 2019 10:00:42 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191030140042.3F7AD20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01088.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447 ...................................................................... Patch Set 1: (3 comments) Basically fine, few minor issues I think need addressing before it can be merged. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/1/gdb/arm-tdep.c File gdb/arm-tdep.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/1/gdb/arm-tdep.c@101 PS1, Line 101: 92 | struct arm_per_bfd 93 | { 94 | explicit arm_per_bfd (size_t num_sections) 95 | : section_maps (new arm_mapping_symbol_vec[num_sections]), 96 | section_maps_sorted (new bool[num_sections] ()) 97 | {} 98 | 99 | DISABLE_COPY_AND_ASSIGN (arm_per_bfd); 100 | 101 | /* Information about mapping symbols ($a, $d, $t) in the objfile. Should this mention of objfile be changed to "bfd" or "bfd object"? https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/1/gdb/testsuite/gdb.arch/pr25124.S File gdb/testsuite/gdb.arch/pr25124.S: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/1/gdb/testsuite/gdb.arch/pr25124.S@4 PS1, Line 4: 1 | /* Test proper disassembling of ARM thumb instructions when reloading a symbol 2 | file. 3 | 4 | Copyright 2012-2019 Free Software Foundation, Inc. This year should be 2019 only unless (1) it's a copy of another file that was added in 2012, or (2) this patch was originally submitted in 2012. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/1/gdb/testsuite/gdb.arch/pr25124.exp File gdb/testsuite/gdb.arch/pr25124.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/1/gdb/testsuite/gdb.arch/pr25124.exp@33 PS1, Line 33: 24 | standard_testfile .S 25 | 26 | if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable debug] != "" } { 27 | untested "failed to compile" 28 | return -1 29 | } 30 | 31 | gdb_test "x /i main+8" 32 | "$hex :\[ \t\]+bx\[ \t\]+lr" 33 | "disassemble thumb instruction (1st try)" Maybe I'm going crazy, but doesn't like 31 and 32 need to end in a trailing backslash? The next call to gdb_test does, and then the third below again, no backslash. I don't have an ARM target to hand, but does this test run correctly like this? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I22c3e6ebe9bfedad66d56fe9656994fa1761c485 Gerrit-Change-Number: 447 Gerrit-PatchSet: 1 Gerrit-Owner: Luis Machado Gerrit-CC: Andrew Burgess Gerrit-Comment-Date: Wed, 30 Oct 2019 14:00:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment