From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27420 invoked by alias); 29 Oct 2019 19:54:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27387 invoked by uid 89); 29 Oct 2019 19:54:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2019 19:54:22 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6573A20D4D; Tue, 29 Oct 2019 15:54:21 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 67935203A5; Tue, 29 Oct 2019 15:54:20 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 4584720AF6; Tue, 29 Oct 2019 15:54:20 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 29 Oct 2019 19:54:00 -0000 From: "Tom Tromey (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] infcall: handle pass-by-reference arguments appropriately X-Gerrit-Change-Id: I18fa5d0df814dfa0defe9e862a88a6dbf1d99d01 X-Gerrit-Change-Number: 141 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8b4d2a3eec0907c24de8d9a5897d3fb014f09ba5 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 29 Oct 2019 15:54:20 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191029195420.4584720AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01051.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/141 ...................................................................... Patch Set 1: Code-Review+2 Thank you. This looks reasonable to me. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I18fa5d0df814dfa0defe9e862a88a6dbf1d99d01 Gerrit-Change-Number: 141 Gerrit-PatchSet: 1 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Tue, 29 Oct 2019 19:54:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment