From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31877 invoked by alias); 29 Oct 2019 19:10:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31861 invoked by uid 89); 29 Oct 2019 19:10:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=suddenly X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2019 19:10:01 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8739D20C06; Tue, 29 Oct 2019 15:09:58 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 94D3120C7E; Tue, 29 Oct 2019 15:09:56 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 78B5A20AF6; Tue, 29 Oct 2019 15:09:56 -0400 (EDT) X-Gerrit-PatchSet: 4 Date: Tue, 29 Oct 2019 19:10:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v4] Only make a nullterminated string if we need to X-Gerrit-Change-Id: I183302e1f51483ff6dff0fd5c3b0f32f0f04a5d2 X-Gerrit-Change-Number: 222 X-Gerrit-ChangeURL: X-Gerrit-Commit: 219d662fda1ce18e437e6b69855d06b920c7e442 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 29 Oct 2019 15:09:56 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191029190956.78B5A20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01041.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/222 ...................................................................... Patch Set 4: Code-Review+2 Thank you. This is ok. I suddenly realized that maybe storing a string_view is confusing because, in reality, the stored strings must always be \0-terminated, because that's how they are used in the rest of the code (via the symbol names). But it seems like if there was a problem, this patch must fix it. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I183302e1f51483ff6dff0fd5c3b0f32f0f04a5d2 Gerrit-Change-Number: 222 Gerrit-PatchSet: 4 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Tue, 29 Oct 2019 19:09:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment