From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31871 invoked by alias); 29 Oct 2019 19:01:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21582 invoked by uid 89); 29 Oct 2019 19:00:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2019 19:00:54 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0578A20D4D; Tue, 29 Oct 2019 15:00:52 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id C85C820C7E; Tue, 29 Oct 2019 15:00:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B0B7E20AF6; Tue, 29 Oct 2019 15:00:48 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 29 Oct 2019 19:01:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Replace bsearch with a std::lower_bound-based search X-Gerrit-Change-Id: I07e0a0e333f4062b27fc68d3a3f24881ebc68fd4 X-Gerrit-Change-Number: 403 X-Gerrit-ChangeURL: X-Gerrit-Commit: ac2a0f1e55a3d1be25c4dc874b40e19eef66be0e In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 29 Oct 2019 15:00:48 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191029190048.B0B7E20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01037.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/403 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Thank you for the patch. I found one nit. The patch is ok with this fixed. No need to re-review. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/403/1/gdb/gdbsupport/gdb_binary_search.h File gdb/gdbsupport/gdb_binary_search.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/403/1/gdb/gdbsupport/gdb_binary_search.h@44 PS1, Line 44: 36 | b, respectively. 37 | [first, last) must be sorted. 38 | 39 | The return value is an iterator pointing to the found element, or LAST if 40 | no element was found. */ 41 | template 42 | It binary_search (It first, It last, T el, Comp comp) 43 | { 44 | auto lt = [&] (const typename std::iterator_traits::value_type& a, 45 | const T& b) The "&"s are in the wrong spots here. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I07e0a0e333f4062b27fc68d3a3f24881ebc68fd4 Gerrit-Change-Number: 403 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Tue, 29 Oct 2019 19:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment