[review v3] Add a string_view version of startswith

Christian Biesinger (Code Review)
2019-10-27T18:23:07Z

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126
......................................................................

Patch Set 3:

> Patch Set 3:
>
> If you base your patch on top of Christian's commit (d441ce34f4d2) and push for review,
> nothing will happen to this patch. Your new patch will just happen to have this one
> as a parent.

Interestingly that was not *quite* my experience when I did something very similar:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/307
that should have tromey's https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/176 as parent, but it doesn't show up that way in Gerrit. However the diff itself shows up correctly, relative to tromey's change.

> If you rebase Christian's patch on master, add yours on top and push for review, then
> it will add a new revision to Christian's patch (assuming the permissions allow it),
> and create yours with this one as a parent. And Christian will be grateful to you for
> rebasing his patch :).
>
> I think that you should try it. For science.

I'm happy to push this, but I'll hold off for now in case you want to try this first. Let me know.

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71
Gerrit-Change-Number: 126
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 27 Oct 2019 18:22:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No