[review v4] Add a string_view version of startswith

Christian Biesinger (Code Review)
2019-10-28T17:20:52Z

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126
......................................................................

Patch Set 4:

> > If you rebase Christian's patch on master, add yours on top and push for review, then
> > it will add a new revision to Christian's patch (assuming the permissions allow it),
> > and create yours with this one as a parent. And Christian will be grateful to you for
> > rebasing his patch :).
> >
> > I think that you should try it. For science.
>
> I'm happy to push this, but I'll hold off for now in case you want to try this first. Let me know.

OK, now that we have the science results :) I am going to push this as requested.

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71
Gerrit-Change-Number: 126
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 28 Oct 2019 17:20:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No