From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56648 invoked by alias); 27 Oct 2019 18:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56636 invoked by uid 89); 27 Oct 2019 18:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=interestingly, (unknown) X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Oct 2019 18:23:05 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7BD5920D4C; Sun, 27 Oct 2019 14:23:03 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 2CCD620D62; Sun, 27 Oct 2019 14:22:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 01AEE20AF6; Sun, 27 Oct 2019 14:22:58 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Sun, 27 Oct 2019 18:23:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Add a string_view version of startswith X-Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71 X-Gerrit-Change-Number: 126 X-Gerrit-ChangeURL: X-Gerrit-Commit: d441ce34f4d241a3a9cb4d246089af81b03cdacc In-Reply-To: References: X-Gerrit-Comment-Date: Sun, 27 Oct 2019 14:22:58 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191027182259.01AEE20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00953.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126 ...................................................................... Patch Set 3: > Patch Set 3: > > If you base your patch on top of Christian's commit (d441ce34f4d2) and push for review, > nothing will happen to this patch. Your new patch will just happen to have this one > as a parent. Interestingly that was not *quite* my experience when I did something very similar: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/307 that should have tromey's https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/176 as parent, but it doesn't show up that way in Gerrit. However the diff itself shows up correctly, relative to tromey's change. > If you rebase Christian's patch on master, add yours on top and push for review, then > it will add a new revision to Christian's patch (assuming the permissions allow it), > and create yours with this one as a parent. And Christian will be grateful to you for > rebasing his patch :). > > I think that you should try it. For science. I'm happy to push this, but I'll hold off for now in case you want to try this first. Let me know. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71 Gerrit-Change-Number: 126 Gerrit-PatchSet: 3 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Sun, 27 Oct 2019 18:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment