From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>
Subject: [review v3] Add a string_view version of startswith
Date: Sun, 27 Oct 2019 01:49:00 -0000 [thread overview]
Message-ID: <20191027014832.598582A7D7@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571229547000.I5389855de2fd70e7065a789a79374b0693651b71@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126
......................................................................
Patch Set 3:
That part of my previous comment is misleading:
> On 2019-10-26 7:10 p.m., Tom Tromey (Code Review) wrote:
I replied by email, so that's the header my email client added when replying to Tom's comment, and Gerrit interpreted it as part of my comment.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71
Gerrit-Change-Number: 126
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 27 Oct 2019 01:48:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-27 1:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 12:39 [review] " Christian Biesinger (Code Review)
2019-10-22 19:12 ` [review v2] " Christian Biesinger (Code Review)
2019-10-22 22:14 ` [review v3] " Christian Biesinger (Code Review)
2019-10-25 17:35 ` Tom Tromey (Code Review)
2019-10-26 23:11 ` Tom Tromey (Code Review)
2019-10-27 1:46 ` Simon Marchi
2019-10-27 1:46 ` Simon Marchi (2) (Code Review)
2019-10-27 1:49 ` Simon Marchi (Code Review) [this message]
2019-10-27 18:23 ` Christian Biesinger (Code Review)
2019-10-27 21:44 ` [review v4] " Tom Tromey (Code Review)
2019-10-27 22:10 ` Simon Marchi (Code Review)
2019-10-28 17:20 ` Christian Biesinger (Code Review)
2019-10-28 17:22 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-28 17:22 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027014832.598582A7D7@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox