[review v3] Add a string_view version of startswith

Simon Marchi (2) (Code Review)
2019-10-27T01:46:24Z

Simon Marchi (2) has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126
......................................................................

Patch Set 3:

On 2019-10-26 7:10 p.m., Tom Tromey (Code Review) wrote:

If you base your patch on top of Christian's commit (d441ce34f4d2) and push for review,
nothing will happen to this patch. Your new patch will just happen to have this one
as a parent.

If you rebase Christian's patch on master, add yours on top and push for review, then
it will add a new revision to Christian's patch (assuming the permissions allow it),
and create yours with this one as a parent. And Christian will be grateful to you for
rebasing his patch :).

I think that you should try it. For science.

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71
Gerrit-Change-Number: 126
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Sun, 27 Oct 2019 01:46:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No