From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116174 invoked by alias); 27 Oct 2019 01:46:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115974 invoked by uid 89); 27 Oct 2019 01:46:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Oct 2019 01:46:21 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 483FF20EAD; Sat, 26 Oct 2019 21:46:19 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id ED3A120172; Sat, 26 Oct 2019 21:46:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id D66792A7D7; Sat, 26 Oct 2019 21:46:17 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Sun, 27 Oct 2019 01:46:00 -0000 From: "Simon Marchi (2) (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Add a string_view version of startswith X-Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71 X-Gerrit-Change-Number: 126 X-Gerrit-ChangeURL: X-Gerrit-Commit: d441ce34f4d241a3a9cb4d246089af81b03cdacc In-Reply-To: References: X-Gerrit-Comment-Date: Sat, 26 Oct 2019 21:46:17 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191027014617.D66792A7D7@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00943.txt.bz2 Simon Marchi (2) has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126 ...................................................................... Patch Set 3: On 2019-10-26 7:10 p.m., Tom Tromey (Code Review) wrote: If you base your patch on top of Christian's commit (d441ce34f4d2) and push for review, nothing will happen to this patch. Your new patch will just happen to have this one as a parent. If you rebase Christian's patch on master, add yours on top and push for review, then it will add a new revision to Christian's patch (assuming the permissions allow it), and create yours with this one as a parent. And Christian will be grateful to you for rebasing his patch :). I think that you should try it. For science. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71 Gerrit-Change-Number: 126 Gerrit-PatchSet: 3 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Sun, 27 Oct 2019 01:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment