[review v2] Only make a nullterminated string if we need to

["Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/222
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> Thanks for the patch.
> 
> The patch moves the `linkage_name_copy` code a bit lower.
> But, I think this copy is actually no longer needed at all, and
> so the code can be removed.  The only real (non-flag) use of
> linkage_name_copy is to again copy:
> 
> 	  strcpy (mangled_ptr, linkage_name_copy);
> 
> ... but this could be replaced by a memcpy and then a store of
> the trailing \0.
> 
> Wouldn't this change also re-enable the string_view change?
> It seems that way to me, but I wonder if I am missing something here.

I did update the patch to use the memcpy.

There are still two issues blocking the string_view change:
- The demangle call mentioned in my previous comment. This could be addressed by just always doing alloca + memcpy, which should be relatively cheap compared to the actual demangling, I'd think
- Even if copy_name==false, this function will still copy the name if it is not nullterminated (it has to, because general_symbol_info expects a nullterminated string). This could be fixed by adding a size to general_symbol_info. That should be doable, and I'll look into it

However, I think this patch is good even before solving those two issues.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I183302e1f51483ff6dff0fd5c3b0f32f0f04a5d2
Gerrit-Change-Number: 222
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 20:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment