From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102590 invoked by alias); 25 Oct 2019 19:10:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102515 invoked by uid 89); 25 Oct 2019 19:10:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2019 19:10:18 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8A97D2105F; Fri, 25 Oct 2019 15:10:16 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 6949C211BC; Fri, 25 Oct 2019 15:10:10 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 40D9B204C9; Fri, 25 Oct 2019 15:10:10 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Fri, 25 Oct 2019 19:10:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey , Simon Marchi , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Don't make an extra copy + allocation of the demangled name X-Gerrit-Change-Id: Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0 X-Gerrit-Change-Number: 132 X-Gerrit-ChangeURL: X-Gerrit-Commit: 441b08b829e88ef398001fe0f99b791a82d0a61f In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 25 Oct 2019 15:10:10 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191025191010.40D9B204C9@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00931.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132 ...................................................................... Patch Set 3: (2 comments) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/3/gdb/symtab.c File gdb/symtab.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/3/gdb/symtab.c@897 PS3, Line 897: if (!copy_name) I reverted the change on this line; I'm no longer sure it's correct. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/3/gdb/symtab.c@914 PS3, Line 914: char *mangled_ptr = reinterpret_cast (*slot + 1); > Formatting should be `` here (missing a space). Thanks, done. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0 Gerrit-Change-Number: 132 Gerrit-PatchSet: 3 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Fri, 25 Oct 2019 19:10:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tom Tromey Gerrit-MessageType: comment