From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29495 invoked by alias); 25 Oct 2019 17:32:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29487 invoked by uid 89); 25 Oct 2019 17:32:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=inhibit, HX-Languages-Length:2040 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2019 17:32:14 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 9FC6A20B46; Fri, 25 Oct 2019 13:32:12 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 4472720E5F; Fri, 25 Oct 2019 13:32:11 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id AD57D204C9; Fri, 25 Oct 2019 13:32:09 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Fri, 25 Oct 2019 17:32:00 -0000 From: "Tom Tromey (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] [RFC][gdb] Make script-extension strict reject unknown extensions X-Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576 X-Gerrit-Change-Number: 40 X-Gerrit-ChangeURL: X-Gerrit-Commit: 15ebbb078ea84b2c0443ebb993abcb8e09cd770a In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 25 Oct 2019 13:32:09 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191025173209.AD57D204C9@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00918.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40 ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Thanks for the patch. This idea seems reasonable enough to me. I'm going to mark this "-1" since it needs documentation still (and probably NEWS). This lets it show up as reviewed in gerrit, but shouldn't be taken to mean some sort of rejection. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2//COMMIT_MSG Commit Message: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2//COMMIT_MSG@53 PS2, Line 53: Setting script-extension to force doesn't inhibit reading: I guess s/force/strict/ here? https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2/gdb/cli/cli-cmds.c File gdb/cli/cli-cmds.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2/gdb/cli/cli-cmds.c@624 PS2, Line 624: script FILE, which has already been opened as STREAM. : FILE_TO_OPEN is the form of FILE to use if one needs to open the file. : This is provided as FILE may have been found via the source search path. : An important thing to note here is that FILE may be a symlink to a file : with a different or non-existing suffix, and thus one cannot infer the : extension language from FILE_TO_OPEN. */ : : static void : source_script_from_stream (FILE *stream, const char *file, : The comment should be updated to document FORCE. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576 Gerrit-Change-Number: 40 Gerrit-PatchSet: 2 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Tom Tromey Gerrit-Reviewer: Tom de Vries Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Fri, 25 Oct 2019 17:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment