From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36508 invoked by alias); 24 Oct 2019 19:05:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36202 invoked by uid 89); 24 Oct 2019 19:05:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Oct 2019 19:05:27 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id AB2F320B46; Thu, 24 Oct 2019 15:05:25 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id B91B120492; Thu, 24 Oct 2019 15:05:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A87A8204C9; Thu, 24 Oct 2019 15:05:17 -0400 (EDT) X-Gerrit-PatchSet: 5 Date: Thu, 24 Oct 2019 19:05:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey , Tom de Vries , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] Load system gdbinit files from a directory X-Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2 X-Gerrit-Change-Number: 26 X-Gerrit-ChangeURL: X-Gerrit-Commit: eca839c42e9fd7c5dd7fff3e5612fd85c8fc865b In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 24 Oct 2019 15:05:16 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191024190517.A87A8204C9@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00898.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26 ...................................................................... Uploaded patch set 5. (3 comments) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c File gdb/main.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@268 PS3, Line 268: if (dir != nullptr) > Well, I think it looks a bit unnatural, but I don't have a strong opinion. […] OK, I changed the indentation. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/4/gdb/main.c File gdb/main.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/4/gdb/main.c@293 PS4, Line 293: files.push_back (filename); > I think this could use `std::move (filename)`. Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/4/gdb/main.c@1038 PS4, Line 1038: for (const std::string& file : system_gdbinit) > should be " &file", not "& file" in the gdb style. Thanks, done. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2 Gerrit-Change-Number: 26 Gerrit-PatchSet: 5 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Tom de Vries Gerrit-CC: Simon Marchi Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Thu, 24 Oct 2019 19:05:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Biesinger Comment-In-Reply-To: Tom Tromey Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment